Re: [PATCH] [net-next] net: ipconfig: move ic_nameservers_fallback into #ifdef block

From: Simon Horman
Date: Fri May 19 2023 - 09:07:20 EST


On Fri, May 19, 2023 at 11:32:38AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The new variable is only used when IPCONFIG_BOOTP is defined and otherwise
> causes a warning:
>
> net/ipv4/ipconfig.c:177:12: error: 'ic_nameservers_fallback' defined but not used [-Werror=unused-variable]
>
> Move it next to the user.
>
> Fixes: 81ac2722fa19 ("net: ipconfig: Allow DNS to be overwritten by DHCPACK")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks Arnd,

I was able to observe this too.

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>