Re: [PATCH net-next v2 2/7] net: dsa: mv88e6xxx: pass directly chip structure to mv88e6xxx_phy_is_internal

From: Russell King (Oracle)
Date: Fri May 19 2023 - 10:36:31 EST


On Fri, May 19, 2023 at 04:12:58PM +0200, alexis.lothore@xxxxxxxxxxx wrote:
> From: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx>
>
> Since this function is a simple helper, we do not need to pass a full
> dsa_switch structure, we can directly pass the mv88e6xxx_chip structure.
> Doing so will allow to share this function with any other function
> not manipulating dsa_switch structure but needing info about number of
> internal phys
>
> Signed-off-by: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx>

Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!