Re: [PATCH] [v2] x86: xen: add missing prototypes

[Boris Ostrovsky]

On 5/19/23 5:28 AM, Arnd Bergmann wrote:

> diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h
> index 22fb982ff971..81a7821dd07f 100644
> --- a/arch/x86/xen/smp.h
> +++ b/arch/x86/xen/smp.h
> @@ -1,7 +1,11 @@
>   /* SPDX-License-Identifier: GPL-2.0 */
>   #ifndef _XEN_SMP_H
>   
> +void asm_cpu_bringup_and_idle(void);
> +asmlinkage void cpu_bringup_and_idle(void);

These can go under CONFIG_SMP

> +
>   #ifdef CONFIG_SMP
> +
>   extern void xen_send_IPI_mask(const struct cpumask *mask,
>   			      int vector);
>   extern void xen_send_IPI_mask_allbutself(const struct cpumask *mask,
> diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
> index a92e8002b5cf..d5ae5de2daa2 100644



> diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h
> index 6d7f6318fc07..0f71ee3fe86b 100644
> --- a/arch/x86/xen/xen-ops.h
> +++ b/arch/x86/xen/xen-ops.h
> @@ -160,4 +160,18 @@ void xen_hvm_post_suspend(int suspend_cancelled);
>   static inline void xen_hvm_post_suspend(int suspend_cancelled) {}
>   #endif
>   
> +void xen_force_evtchn_callback(void);

These ...

> +pteval_t xen_pte_val(pte_t pte);
> +pgdval_t xen_pgd_val(pgd_t pgd);
> +pte_t xen_make_pte(pteval_t pte);
> +pgd_t xen_make_pgd(pgdval_t pgd);
> +pmdval_t xen_pmd_val(pmd_t pmd);
> +pmd_t xen_make_pmd(pmdval_t pmd);
> +pudval_t xen_pud_val(pud_t pud);
> +pud_t xen_make_pud(pudval_t pud);
> +p4dval_t xen_p4d_val(p4d_t p4d);
> +p4d_t xen_make_p4d(p4dval_t p4d);
> +pte_t xen_make_pte_init(pteval_t pte);
> +void xen_start_kernel(struct start_info *si);


... should go under '#ifdef CONFIG_XEN_PV'



-boris