Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic

From: Kent Overstreet
Date: Sat May 20 2023 - 01:53:07 EST


On Fri, May 19, 2023 at 09:17:43PM -0700, Christoph Hellwig wrote:
> On Sat, May 20, 2023 at 12:13:49AM -0400, Kent Overstreet wrote:
> > I suppose this way setting it can be done in bio_iov_iter_get_pages() -
> > ok yeah, that makes sense.
> >
> > But it seems like it should be set in bio_iov_iter_get_pages() though,
> > and I'm not seeing that?
>
> It is set in bio_iov_iter_get_pages in this patch. The later gets
> replaced with the pinned flag when we bio_iov_iter_get_pages is
> changed to pin pages instead.

Whoops, missed it.

Reviewed-by: Kent Overstreet <kent.overstreet@xxxxxxxxx>