Re: [PATCH v5 3/8] net-next: mvpp2: relax return value check for IRQ get

[Matti Vaittinen]

Hi Andy,

On 5/21/23 20:19, andy.shevchenko@xxxxxxxxx wrote:
> Fri, May 19, 2023 at 02:01:47PM +0300, Matti Vaittinen kirjoitti:
> > fwnode_irq_get[_byname]() were changed to not return 0 anymore.
> >
> > Drop check for return value 0.
>
> ...
>
> > -		if (v->irq <= 0) {
> > +		if (v->irq < 0) {
> >   			ret = -EINVAL;
>
> 			ret = v->irq;
>
> ?

For me that seems to be correct, yes. This, however, would be a 
functional change and in my opinion it should be done separately from 
this API change.

> >   			goto err;
> >   		}

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~