RE: [PATCH 6.3 000/364] 6.3.4-rc1 review

From: Chris Paterson
Date: Mon May 22 2023 - 16:29:37 EST


Hello Greg,

> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Monday, May 22, 2023 8:05 PM
>
> This is the start of the stable review cycle for the 6.3.4 release.
> There are 364 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 24 May 2023 19:03:25 +0000.
> Anything received after that time might be too late.

I'm seeing a few build failures with Linux 6.3.4-rc1 (20efcce0526d) due to the drivers/usb/host/xhci.c driver:

drivers/usb/host/xhci.c:497:19: error: static declaration of 'xhci_try_enable_msi' follows non-static declaration
497 | static inline int xhci_try_enable_msi(struct usb_hcd *hcd)
| ^~~~~~~~~~~~~~~~~~~
In file included from drivers/usb/host/xhci.c:22:
drivers/usb/host/xhci.h:2146:5: note: previous declaration of 'xhci_try_enable_msi' was here
2146 | int xhci_try_enable_msi(struct usb_hcd *hcd);
| ^~~~~~~~~~~~~~~~~~~

Example build failure: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/4328533790#L2178
Pipeline: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/875108293

Commit 78887e3e5f00 ("xhci: Avoid PCI MSI/MSIX interrupt reinitialization at resume") adds the offending code.
I'm only seeing this for the 6.3 rc.

Kind regards, Chris