Re: [PATCH] drm/radeon: Replace all non-returning strlcpy with strscpy

From: Kees Cook
Date: Mon May 22 2023 - 16:55:01 EST


On Mon, 22 May 2023 15:50:32 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]

Applied to for-next/hardening, thanks!

[1/1] drm/radeon: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/76ea3f6ef93f

--
Kees Cook