Re: [PATCH v9 2/2] hwmon: max31827: add MAX31827 driver

[Guenter Roeck]

On Mon, May 22, 2023 at 02:18:11PM +0000, Matyas, Daniel wrote:
> 
> 
> -----Original Message-----
> From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck
> Sent: Monday, May 22, 2023 4:25 PM
> To: Matyas, Daniel <Daniel.Matyas@xxxxxxxxxx>
> Cc: kernel test robot <lkp@xxxxxxxxx>; Jean Delvare <jdelvare@xxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v9 2/2] hwmon: max31827: add MAX31827 driver
> 
> [External]
> 
> On Tue, May 16, 2023 at 01:46:07PM +0300, Daniel Matyas wrote:
> > MAX31827 is a low-power temperature switch with I2C interface.
> > 
> > The device is a ±1°C accuracy from -40°C to +125°C
> > (12 bits) local temperature switch and sensor with I2C/SM- Bus 
> > interface. The combination of small 6-bump wafer-lev- el package (WLP) 
> > and high accuracy makes this temper- ature sensor/switch ideal for a 
> > wide range of applications.
> > 
> > Signed-off-by: Daniel Matyas <daniel.matyas@xxxxxxxxxx>
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Link: 
> > https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/2023
> > 05112351.DBkFfs76-lkp@xxxxxxxxx/__;!!A3Ni8CS0y2Y!5SeqSdRyCHcgA6Se6U-EN
> > I_MJfRPgB-FEVkuwWyb944DQypaZ5XQAS6N3aZiVDd1LZDGK45xp7KJHH8RSzw$
> > ---
> 
> Change log goes here. Without it, I'll have to manually re-review and compare against previous versions and look up comments to ensure that all feedback has been addressed. That will take time, which is always
> scarce.   don't have right now. My apologies, but that means that
> review and acceptance of your driver will be delayed.
> 
> Guenter
> 
> 
> Dear Guenter,
> 
> I didn't write a changelog, because I changed literally nothing in the code. I sent a new patch, because in the previous Krzysztof Kozlowski asked me to remove the '--base' when using 'git format-patch'. I wrote this to commit 1/2, but consider it necessary to write the same thing again in patch 2/2.
> 

In that case the appropriate change log would have been "no change
against v8", or "unchanged". Also, the change log should really include
all changes since v1, separated for each version.

v9: No change
v8: xxx
v7: yyy
...

Guenter

> I have the Reported-by flag, because I forgot to add it in patch v8.
> 
> I am sorry for the confusion!
> 
> Best regards,
> Daniel Matyas