Re: [syzbot] [rdma?] INFO: trying to register non-static key in skb_dequeue (2)

[Guoqing Jiang]

On 5/23/23 12:29, Zhu Yanjun wrote:
> On Tue, May 23, 2023 at 12:10 PM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote:
> > On 5/23/23 12:02, Zhu Yanjun wrote:
> > > On Tue, May 23, 2023 at 11:47 AM Zhu Yanjun <zyjzyj2000@xxxxxxxxx> wrote:
> > > > On Tue, May 23, 2023 at 10:26 AM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote:
> > > > > On 5/23/23 10:13, syzbot wrote:
> > > > > > Hello,
> > > > > >
> > > > > > syzbot tried to test the proposed patch but the build/boot failed:
> > > > > >
> > > > > > failed to apply patch:
> > > > > > checking file drivers/infiniband/sw/rxe/rxe_qp.c
> > > > > > patch: **** unexpected end of file in patch
> > > > This is not the root cause. The fix is not good.
> > > This problem is about "INFO: trying to register non-static key. The
> > > code is fine but needs lockdep annotation, or maybe"
> This warning is from "lock is not initialized". This is a
> use-before-initialized problem.

Right, and it also applies to qp->sq.queue which is set to NULL while do 
cleanup
still de-reference it.

> The correct fix is to initialize the lock that is complained before it is used.

The thing is it can't be initialized due to error, so I guess you want 
to always init them
even for error cases.

Guoqing