Re: [PATCH v3] gpio: tegra186: Check GPIO pin permission before access.

From: Bartosz Golaszewski
Date: Tue May 23 2023 - 05:18:21 EST


On Tue, May 23, 2023 at 8:22 AM Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>
>
> On 17/10/2022 10:31, Linus Walleij wrote:
> > On Fri, Oct 7, 2022 at 7:59 AM Prathamesh Shete <pshete@xxxxxxxxxx> wrote:
> >
> >> This change checks if we have the necessary permission to
> >> access the GPIO. For devices that have support for virtualisation
> >> we need to check both the TEGRA186_GPIO_VM_REG and the
> >> TEGRA186_GPIO_SCR_REG registers. For device that do not have
> >> virtualisation support for GPIOs we only need to check the
> >> TEGRA186_GPIO_SCR_REG register.
> >>
> >> Signed-off-by: Manish Bhardwaj <mbhardwaj@xxxxxxxxxx>
> >> Signed-off-by: Prathamesh Shete <pshete@xxxxxxxxxx>
> >
> > Very nice patch!
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
>
> I did not see this anywhere in the mainline/next. However, I also
> noticed that we don't have the correct email address for Bartosz (again).
>

I have only ever changed my address in MAINTAINERS once, so "again" is
not really the right term. And scripts/get_maintainer.pl should be
used anyway every time when submitting patches.

> Bartosz, let me know if you can pick this up? Thierry also ack'ed
> previously for Tegra too.
>
> FWIW ...
>
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>

This doesn't apply to v6.4-rc1. Prathmesh: could you rebase and resend?

Bart

> Thanks
> Jon
>
> --
> nvpublic