Re: [PATCH] pinctrl:sunplus: Add check for kmalloc

[andy . shevchenko]

Tue, May 23, 2023 at 06:11:28PM +0800, Wells Lu kirjoitti:
> Fix Smatch static checker warning:
> potential null dereference 'configs'. (kmalloc returns null)

...

>  			configs = kmalloc(sizeof(*configs), GFP_KERNEL);
> +			if (!configs)

> +				return -ENOMEM;

"Fixing" by adding a memory leak is not probably a good approach.

...

>  			configs = kmalloc(sizeof(*configs), GFP_KERNEL);
> +			if (!configs)
> +				return -ENOMEM;

Ditto.

...

It might be that I'm mistaken. In this case please add an explanation why in
the commit message.

-- 
With Best Regards,
Andy Shevchenko