Re: [PATCH -next] cgroup: Remove out-of-date comment in cgroup_migrate()
From: Tejun Heo
Date: Tue May 23 2023 - 15:09:27 EST
On Tue, May 23, 2023 at 07:14:56PM +0800, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>
>
> Commit 674b745e22b3 ("cgroup: remove rcu_read_lock()/rcu_read_unlock()
> in critical section of spin_lock_irq()") has removed the rcu_read_lock,
> which makes the comment out-of-date, so remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>
So, that removed rcu_read_lock() because it's implied by the irq disable but
the comment content is still useful in describing what's preventing
use-after-free. Can you please update the comment accordingly instead?
Thanks.
--
tejun