Re: [PATCH v2] fscrypt: Replace 1-element array with flexible array

From: Eric Biggers
Date: Tue May 23 2023 - 22:55:38 EST


On Tue, May 23, 2023 at 09:55:02AM -0700, Kees Cook wrote:
> 1-element arrays are deprecated and are being replaced with C99
> flexible arrays[1].
>
> As sizes were being calculated with the extra byte intentionally,
> propagate the difference so there is no change in binary output.
>
> [1] https://github.com/KSPP/linux/issues/79
>
> Cc: Eric Biggers <ebiggers@xxxxxxxxxx>
> Cc: "Theodore Y. Ts'o" <tytso@xxxxxxx>
> Cc: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> Cc: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> Cc: linux-fscrypt@xxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> v2: update commit log to avoid mentioning "len" member.
> v1: https://lore.kernel.org/lkml/20230522213924.never.119-kees@xxxxxxxxxx/
> ---
> fs/crypto/fscrypt_private.h | 2 +-
> fs/crypto/hooks.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)

Thanks, applied to
https://git.kernel.org/pub/scm/fs/fscrypt/linux.git/log/?h=for-next

- Eric