Re: [PATCH v3 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq()

[Jonathan Cameron]

On Wed, 25 Feb 2026 13:59:20 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Tue, Feb 24, 2026 at 04:48:18PM -0600, Ethan Tidmore wrote:
> > The triggered buffer is initialized before the IRQ is requested. The
> > removal path currently calls  iio_triggered_buffer_cleanup() before 
> > free_irq(). This violates the expected LIFO. 
> > 
> > Place free_irq() in correct location.  
> 
> "Place free_irq() in the correct location."
> 
> 
> > - Clarify patch purpose  
> 
> Still doesn't give me enough clarity.
> 
> The patch as I read it doesn't move free_irq().

I went with
Place free_irq() in the correct location relative to
iio_triggered_buffer_cleanup().

As a Englishman I do always appreciate Andy adding the missing "the" which
I think of as an American thing :)  You really don't want to know how
many editing wars I've had over that in some specifications.

Jonathan

> 
> ...
> 
> But I leave it to native speaker and maintainer to decide. No need to resend.
>