Re: [PATCH v5 1/2] iio: frequency: ad9832: remove kernel.h proxy header
From: Andy Shevchenko
Date: Thu Apr 16 2026 - 04:37:57 EST
On Thu, Apr 16, 2026 at 06:51:17AM +0000, Joshua Crofts wrote:
Sorry that I missed some key points in the previous reviews (see below).
v6 is needed.
...
> Remove kernel.h proxy header and add bitops.h for
> better dependency control and code clarity. Also
> removed slab.h and moved asm header below generic
> <linux/*> headers.
The comment uses too short lines (50), use up to ~72 characters per line,
please.
> Audited using include-what-you-use.
While I gave a tag, it still seems need an improvement, id est
there are missing headers:
array_size.h
dev_printk.h
kstrtox.h
mod_devicetable.h
mutex.h
types.h
asm/byteorder.h
and unneeded one(s):
device.h
--
With Best Regards,
Andy Shevchenko