Re: [PATCH v5 1/2] iio: frequency: ad9832: remove kernel.h proxy header

From: Joshua Crofts

Date: Fri Apr 17 2026 - 05:57:56 EST


On Thu, 16 Apr 2026 at 10:34, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
> While I gave a tag, it still seems need an improvement, id est
> there are missing headers:
>
> array_size.h
> dev_printk.h
> kstrtox.h
> mod_devicetable.h
> mutex.h
> types.h
>
> asm/byteorder.h
>
> and unneeded one(s):
> device.h

Adding the headers above is fine, but removing device.h even
if there are things like struct device_attribute in the code? I know
linux/iio/iio.h includes device.h but I thought that we're trying to
eliminate these "includes in includes" unless they're trivial (like
linux/bits.h in linux/bitops.h).

--
Kind regards

CJD