Re: [PATCH v5 1/2] iio: frequency: ad9832: remove kernel.h proxy header

[Andy Shevchenko]

On Fri, Apr 17, 2026 at 11:41:28AM +0200, Joshua Crofts wrote:
> On Thu, 16 Apr 2026 at 10:34, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > While I gave a tag, it still seems need an improvement, id est
> > there are missing headers:
> >
> > array_size.h
> > dev_printk.h
> > kstrtox.h
> > mod_devicetable.h
> > mutex.h
> > types.h
> >
> > asm/byteorder.h
> >
> > and unneeded one(s):
> > device.h
> 
> Adding the headers above is fine, but removing device.h even
> if there are things like struct device_attribute in the code?

I don't see it's in use. The pointer to it yes, but it's a huge
difference.  https://en.wikipedia.org/wiki/Opaque_pointer

> I know linux/iio/iio.h includes device.h but I thought that we're trying to
> eliminate these "includes in includes" unless they're trivial (like
> linux/bits.h in linux/bitops.h).

-- 
With Best Regards,
Andy Shevchenko