Re: [PATCH] iio: accel: mma8452: use pm_ptr() for dev_pm_ops
From: kernel test robot
Date: Thu Apr 16 2026 - 11:37:56 EST
Hi Sanjay,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v7.0 next-20260415]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sanjay-Chitroda/iio-accel-mma8452-use-pm_ptr-for-dev_pm_ops/20260416-061819
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20260414192045.3598010-1-sanjayembedded%40gmail.com
patch subject: [PATCH] iio: accel: mma8452: use pm_ptr() for dev_pm_ops
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260416/202604162323.4pYsEj7A-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260416/202604162323.4pYsEj7A-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604162323.4pYsEj7A-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/iio/accel/mma8452.c:1776:12: warning: 'mma8452_runtime_resume' defined but not used [-Wunused-function]
1776 | static int mma8452_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/accel/mma8452.c:1747:12: warning: 'mma8452_runtime_suspend' defined but not used [-Wunused-function]
1747 | static int mma8452_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/mma8452_runtime_resume +1776 drivers/iio/accel/mma8452.c
c7eeea93ac60ab Peter Meerwald 2014-02-05 1746
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 @1747 static int mma8452_runtime_suspend(struct device *dev)
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1748 {
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1749 struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1750 struct mma8452_data *data = iio_priv(indio_dev);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1751 int ret;
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1752
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1753 mutex_lock(&data->lock);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1754 ret = mma8452_standby(data);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1755 mutex_unlock(&data->lock);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1756 if (ret < 0) {
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1757 dev_err(&data->client->dev, "powering off device failed\n");
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1758 return -EAGAIN;
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1759 }
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1760
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1761 ret = regulator_disable(data->vddio_reg);
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1762 if (ret) {
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1763 dev_err(dev, "failed to disable VDDIO regulator\n");
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1764 return ret;
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1765 }
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1766
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1767 ret = regulator_disable(data->vdd_reg);
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1768 if (ret) {
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1769 dev_err(dev, "failed to disable VDD regulator\n");
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1770 return ret;
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1771 }
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1772
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1773 return 0;
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1774 }
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1775
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 @1776 static int mma8452_runtime_resume(struct device *dev)
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1777 {
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1778 struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1779 struct mma8452_data *data = iio_priv(indio_dev);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1780 int ret, sleep_val;
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1781
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1782 ret = regulator_enable(data->vdd_reg);
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1783 if (ret) {
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1784 dev_err(dev, "failed to enable VDD regulator\n");
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1785 return ret;
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1786 }
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1787
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1788 ret = regulator_enable(data->vddio_reg);
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1789 if (ret) {
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1790 dev_err(dev, "failed to enable VDDIO regulator\n");
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1791 regulator_disable(data->vdd_reg);
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1792 return ret;
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1793 }
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1794
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1795 ret = mma8452_active(data);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1796 if (ret < 0)
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1797 goto runtime_resume_failed;
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1798
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1799 ret = mma8452_get_odr_index(data);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1800 sleep_val = 1000 / mma8452_samp_freq[ret][0];
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1801 if (sleep_val < 20)
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1802 usleep_range(sleep_val * 1000, 20000);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1803 else
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1804 msleep_interruptible(sleep_val);
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1805
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1806 return 0;
96c0cb2bbfe0a5 Martin Kepplinger 2016-03-03 1807
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1808 runtime_resume_failed:
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1809 regulator_disable(data->vddio_reg);
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1810 regulator_disable(data->vdd_reg);
c7eeea93ac60ab Peter Meerwald 2014-02-05 1811
f6ff49b8a3b6f7 Anson Huang 2019-01-08 1812 return ret;
c7eeea93ac60ab Peter Meerwald 2014-02-05 1813 }
c7eeea93ac60ab Peter Meerwald 2014-02-05 1814
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki