Re: [GIT PULL] smbdirect ksmbd and cifs changes

[Steve French]

On Thu, Apr 16, 2026 at 10:37 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 16 Apr 2026 at 08:04, Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > Move smbdirect server and client code to common
>
> Pulled.
>
> I did want to ask why you ended up with that very odd directory
> structure? Not that it's a problem - I don't expect that I'll ever end
> up doing a lot of pathname autocompletion in this all - but it just
> looks so strangely convoluted...
>
> Just to pick on the biggest file in there ("it's not fat, it just has
> thicc code") that also has the longest name:
>
>    fs/smb/common/smbdirect/smbdirect_connection.c
>
> why the redundant and complicated naming? The *point* of a directory
> structure is to structure your directory contents so that you don't
> need to name your files odd ways..
>
> And yes, it's "common" code, but it's a big subsystem of its own, and
> got its own subdirectory anyway and it all could just have been
>
>    fs/smb/smbdirect/connection.c

That makes sense.  Will ask Metze to make that update from
fs/smb/common/smbdirect/ to shorter path fs/smb/smbdirect/


-- 
Thanks,

Steve