Re: [PATCH v3] nvme-auth: Include SC_C in RVAL controller hash

[Hannes Reinecke]

On 4/17/26 02:50, alistair23@xxxxxxxxx wrote:
> From: Alistair Francis <alistair.francis@xxxxxxx>
>
> Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is
> included in the Response Value (RVAL) hash and SC_C should be included.
> Currently we are hardcoding 0 instead of using the correct SC_C value.
>
> Update the host and target code to use the SC_C when calculating the
> RVAL instead of using 0.
>
> Fixes: e88a7595b57f2 ("nvme-tcp: request secure channel concatenation")
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> Reviewed-by: Chris Leech <cleech@xxxxxxxxxx>
> ---
> v3:
>   - Update Fixes tag
> v2:
>   - Rebase using new nvme_auth_hmac_update() functions
>
>   drivers/nvme/host/auth.c   | 3 ++-
>   drivers/nvme/target/auth.c | 3 ++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich