Re: [PATCH] drm/nouveau/gsp: Fix possible NULL pointer dereference warning in r535_dmac_alloc

[Timur Tabi]

On Sat, 2026-04-18 at 19:35 +0200, Danilo Krummrich wrote:
> > I posted a patch a couple months ago that cleans up an IS_ERR check, but it was never picked
> > up:
> 
> Thanks! Can you please make sure to send patches to all maintainers? If they
> don't land in my inbox, I can't pick them up. :(

M:  Lyude Paul <lyude@xxxxxxxxxx>
M:  Danilo Krummrich <dakr@xxxxxxxxxx>

Hmmmm.... I did CC Lyude, but you're right.  I should update my git-email script to catch these
better.

While I have your attention, I do have other patches that I neglected to CC you on:

  2. [PATCH 6/6] drm/nouveau/gsp: enable FWSEC-SB on GA100
     - by Timur Tabi @ 2026-04-07 19:21 UTC [95%]

  3. [PATCH 2/6] drm/nouveau/bios: specify correct display fuse register for Ampere and Ada
     - by Timur Tabi @ 2026-04-07 19:21 UTC [95%]

  4. [PATCH 1/6] drm/nouveau: check for GA100 specifically when calculating FRTS size
     - by Timur Tabi @ 2026-04-07 19:21 UTC [91%]

  5. [PATCH 4/6] drm/nouveau/gsp: require GSP-RM for GA100 support
     - by Timur Tabi @ 2026-04-07 19:21 UTC [97%]

  6. [PATCH 3/6] drm/nouveau/bios: skip the IFR header if present
     - by Timur Tabi @ 2026-04-07 19:21 UTC [75%]

  7. [PATCH 5/6] drm/nouveau: parse the VBIOS on GA100
     - by Timur Tabi @ 2026-04-07 19:21 UTC [99%]

  8. [PATCH 0/6] drm/nouveau: fix GA100 issues
     - by Timur Tabi @ 2026-04-07 19:21 UTC [93%]

  9. [PATCH] drm/nouveau: expose VBIOS via debugfs on GSP-RM systems
     - by Timur Tabi @ 2026-04-07 18:53 UTC [95%]

> 
> > https://lore.freedesktop.org/nouveau/20260103000756.1002890-1-ttabi@xxxxxxxxxx/T/#u
> > 
> > I'm quite certain that there are other similar issues in Nouveau w.r.t. IS_ERR_OR_NULL.
> 
> Yeah, that sounds likely.
> 
> > I think an audit of the Nouveau error paths is in order.  I suspect that Ben's big refactors
> > over the past year have resulted in some invalid error paths.
> 
> Are you planning to look into this?

No, but it does sound like something that Claude could figure out pretty quick.