Re: [PATCH 1/2] mailbox: add sanity check for channel array

[Wolfram Sang]

> This sounds like a quick suggestion from some AI tool -- looks nice
> but doesn't mean much.

Nope, from the cover letter:

While diving deeper into this subsystem, I manually found these two
issues which I wanted to fix right away.

I just wanted to check which parameters are required and which are
optional. And the array is definitely required, so the core should check
for it IMHO.

> point to an array of channels. NULL is just another garbage value, why
> not also check for 0xdeadbabe or 0xffff... ?

Because NULL is what we get if we kzalloc a structure unlike the values
you mentioned.

> I can let loose a claude session and I will find 1000s of such "fixes"
> in the kernel.

No AI was involved in the generation of these patches. I think I marked
the patches which resulted from AI review correctly so far.

Attachment: signature.asc
Description: PGP signature