Re: [PATCH v3 2/4] regulator: qcom-rpmh: Fix PMIC5 BOB bypass mode handling
From: Dmitry Baryshkov
Date: Sat Apr 18 2026 - 20:01:48 EST
On Tue, Apr 07, 2026 at 10:13:30AM +0530, Kamal Wadhwa wrote:
> Currently, when `rpmh_regulator_set_mode_bypass()` helper function
> is called to set bypass mode, it sends PMIC4's BOB bypass mode
> value for even if its a PMIC5 BOB.
>
> To fix this, introduce new hw_data parameter`pmic_bypass_mode`
> to store bypass mode value. Use it to send correct PMIC bypass
> mode value that corresponds to PMIC4/5 BOB regulators from the
> helper function.
>
> Fixes: 610f29e5cc0e8d58 ("regulator: qcom-rpmh: Update PMIC modes for PMIC5")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> ---
> drivers/regulator/qcom-rpmh-regulator.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry