Re: [PATCH 03/23] dmaengine: sdxi: Add PCI initialization

[Lynch, Nathan]

On 4/20/2026 1:36 AM, Frank Li wrote:
>> +static int sdxi_pci_init(struct sdxi_dev *sdxi)
>> +{
>> +     struct pci_dev *pdev = sdxi_to_pci_dev(sdxi);
>> +     struct device *dev = &pdev->dev;
>> +     int ret;
>> +
>> +     ret = pcim_enable_device(pdev);
>> +     if (ret)
>> +             return dev_err_probe(dev, ret, "failed to enable device\n");
>> +
>> +     ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
>> +     if (ret)
>> +             return dev_err_probe(dev, ret, "failed to set DMA masks\n");
> 
> Needn't check return value when mask >= 32.

OK.



>> +     sdxi->ctrl_regs = pcim_iomap_region(pdev, SDXI_PCI_BAR_CTL_REGS,
>> +                                         KBUILD_MODNAME);
>> +     if (IS_ERR(sdxi->ctrl_regs)) {
>> +             return dev_err_probe(dev, PTR_ERR(sdxi->ctrl_regs),
>> +                                  "failed to map control registers\n");
>> +     }
> 
> Does check_patch report warning, suppose needn't {}

I don't think so, but I can drop the braces.


>> +#define SDXI_DRV_DESC                "SDXI driver"
> 
> If only use once, needn't define macro.

OK.