Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4
From: Dmitry Baryshkov
Date: Tue Apr 21 2026 - 21:53:32 EST
On Tue, Apr 21, 2026 at 11:45:14AM +0200, Alexandre MINETTE via B4 Relay wrote:
> From: Alexandre MINETTE <contact@xxxxxxxxxxx>
>
> Add a device tree for the Samsung Galaxy S4, codenamed jflte.
>
> This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support
> covers UART, USB peripheral mode with USB networking, the front LED and
> the physical buttons.
>
> Signed-off-by: Alexandre MINETTE <contact@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/qcom-apq8064-samsung-jflte.dts | 484 +++++++++++++++++++++
> 2 files changed, 485 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 32a44b02d2fa..c23c961f79e3 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-apq8064-ifc6410.dtb \
> qcom-apq8064-sony-xperia-lagan-yuga.dtb \
> qcom-apq8064-asus-nexus7-flo.dtb \
> + qcom-apq8064-samsung-jflte.dtb \
> qcom-apq8064-lg-nexus4-mako.dtb \
> qcom-apq8074-dragonboard.dtb \
> qcom-ipq4018-ap120c-ac.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts b/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts
> new file mode 100644
> index 000000000000..9e5faf7c086f
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8064-samsung-jflte.dts
> @@ -0,0 +1,484 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/mfd/qcom-rpm.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +
> +#include "qcom-apq8064-v2.0.dtsi"
> +#include "pm8821.dtsi"
> +#include "pm8921.dtsi"
> +
> +/ {
> + model = "Samsung Galaxy S4 (jflte)";
> + compatible = "samsung,jflte", "qcom,apq8064";
> + chassis-type = "handset";
> +
> + aliases {
> + serial0 = &gsbi7_serial;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + ramoops@88d00000 {
> + compatible = "ramoops";
> + reg = <0x88d00000 0x100000>;
> + record-size = <0x20000>;
> + console-size = <0x20000>;
> + ftrace-size = <0x20000>;
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> + pinctrl-0 = <&gpio_keys_default>;
> +
> + key-home {
> + label = "Home";
> + gpios = <&pm8921_gpio 30 GPIO_ACTIVE_LOW>;
> + debounce-interval = <5>;
> + linux,code = <KEY_HOME>;
> + wakeup-source;
> + };
> +
> + key-volume-up {
> + label = "Volume Up";
> + gpios = <&pm8921_gpio 35 GPIO_ACTIVE_LOW>;
> + debounce-interval = <5>;
> + linux,code = <KEY_VOLUMEUP>;
> + wakeup-source;
> + };
> +
> + key-volume-down {
> + label = "Volume Down";
> + gpios = <&pm8921_gpio 37 GPIO_ACTIVE_LOW>;
> + debounce-interval = <5>;
> + linux,code = <KEY_VOLUMEDOWN>;
> + wakeup-source;
> + };
> + };
> +
> + i2c-muic {
> + compatible = "i2c-gpio";
> + sda-gpios = <&tlmm_pinmux 22 GPIO_ACTIVE_HIGH>;
> + scl-gpios = <&tlmm_pinmux 23 GPIO_ACTIVE_HIGH>;
> + i2c-gpio,delay-us = <2>;
[...]
> + };
> +
> + i2c-led {
i2c-led should be before i2c-muic
> + compatible = "i2c-gpio";
> + sda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
[...]
> +};
> +
--
With best wishes
Dmitry