Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4

[Konrad Dybcio]

On 4/21/26 11:45 AM, Alexandre MINETTE via B4 Relay wrote:
> From: Alexandre MINETTE <contact@xxxxxxxxxxx>
> 
> Add a device tree for the Samsung Galaxy S4, codenamed jflte.
> 
> This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support
> covers UART, USB peripheral mode with USB networking, the front LED and
> the physical buttons.
> 
> Signed-off-by: Alexandre MINETTE <contact@xxxxxxxxxxx>
> ---

[...]

> +	i2c-muic {
> +		compatible = "i2c-gpio";
> +		sda-gpios = <&tlmm_pinmux 22 GPIO_ACTIVE_HIGH>;
> +		scl-gpios = <&tlmm_pinmux 23 GPIO_ACTIVE_HIGH>;

Is this not GSBI2?

[...]

> +	i2c-led {
> +		compatible = "i2c-gpio";
> +		sda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +		scl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;

Likewise, GSBI3

[...]

> +&riva {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&riva_wlan_pin_a>, <&riva_bt_pin_a>, <&riva_fm_pin_a>;

pinctrl-n
pinctrl-names

in this order please, file-wide

[...]

> +&usb1 {
> +	dr_mode = "otg";
> +	extcon = <&muic>, <&usb_id>;
> +	status = "okay";

Nit: please keep a \n before status

looks fairly good otherwise

Konrad