Re: [PATCH v2 3/3] Documentation: deprecated.rst: kmalloc-family: mark argument as optional
From: Manuel Ebner
Date: Wed Apr 22 2026 - 08:13:31 EST
On Wed, 2026-04-22 at 09:14 +0200, Geert Uytterhoeven wrote:
> Hi Manuel,
>
> Thanks for your patch!
That's good to read.
> On Tue, 21 Apr 2026 at 20:09, Manuel Ebner <manuelebner@xxxxxxxxxxx> wrote:
> > put the optional argument (gfp) in square brackets
> >
> > eg. ptr = kmalloc_obj(*ptr, gfp);
> > -> ptr = kmalloc_obj(*ptr, [gfp]);
>
> Shouldn't that be "[, gfp]", e.g.
>
> kmalloc_obj(*ptr [, gfp]);
I think technically it should be
kmalloc_obj(*ptr[, gfp]);
but that's difficult to grasp, so i went for my notation. Yours
is a good tradeoff. I'll think about it and choose the right one.
>
> everywhere?
>
> > Signed-off-by: Manuel Ebner <manuelebner@xxxxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert