Re: [PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions
From: Krzysztof Kozlowski
Date: Thu Apr 23 2026 - 05:18:45 EST
On Thu, Apr 23, 2026 at 11:28:30AM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> The 'wakeup-source' property already has its type defined in the core
> schema. The Rockchip MFD bindings redundantly specify 'type: boolean'
No, core schema has TWO types.
Defining it as type boolean is not redundant, because
of_property_read_bool() on non-bool is deprecated.
This must be explained somehow - are these device drivers expecting bool
or not?
Best regards,
Krzysztof