Re: [PATCH 1/7] media: qcom: iris: Centralize internal buffer table selection

[Bryan O'Donoghue]

On 22/04/2026 12:16, Dikshita Agarwal wrote:
> +static void iris_get_int_buf_tbl(struct iris_inst *inst, u32 plane,
> +				 const u32 **buf_tbl, u32 *buf_tbl_size)


> +			*buf_tbl = platform_data->enc_op_int_buf_tbl;
> +			*buf_tbl_size = platform_data->enc_op_int_buf_tbl_size;
>   		}
>   	}
>   }
>
> +void iris_get_internal_buffers(struct iris_inst *inst, u32 plane)
> +{
> +	const u32 *internal_buf_type;
> +	u32 internal_buffer_count, i;
> +
> +	iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_count);

I'd suggest mirroring the variable names from caller to callee since it 
makes reading/understanding the code generally easier.

---
bod