Re: [PATCH 1/2] dt-bindings: pci: ultrarisc: add required DP1000 PCIe clocks

[Conor Dooley]

On Mon, Jun 29, 2026 at 01:59:50PM +0800, Jia Wang via B4 Relay wrote:
> From: Jia Wang <wangjia@xxxxxxxxxxxxx>
> 
> Require the DP1000 PCIe controller nodes to provide clocks and
> clock-names, using the standard DesignWare clock names "core",
> "dbi", and "aux".
> 
> Signed-off-by: Jia Wang <wangjia@xxxxxxxxxxxxx>

Probably should have a fixes tag here because the clocks are mandatory
and were missing.
With one,
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: not-applicable

Thanks,
Conor.

> ---
>  .../devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml   | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml b/Documentation/devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml
> index 512b935bf5d1..d9d1488e915a 100644
> --- a/Documentation/devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/ultrarisc,dp1000-pcie.yaml
> @@ -43,6 +43,18 @@ properties:
>        - description: Legacy INTC interrupt
>        - description: Legacy INTD interrupt
>  
> +  clocks:
> +    items:
> +      - description: PCIe core clock
> +      - description: Data Bus Interface (DBI) clock
> +      - description: Auxiliary clock
> +
> +  clock-names:
> +    items:
> +      - const: core
> +      - const: dbi
> +      - const: aux
> +
>    interrupt-names:
>      items:
>        - const: msi
> @@ -55,6 +67,8 @@ required:
>    - compatible
>    - reg
>    - reg-names
> +  - clocks
> +  - clock-names
>    - interrupts
>    - interrupt-names
>  
> @@ -71,6 +85,8 @@ examples:
>          reg = <0x0 0x21000000 0x0 0x01000000>,
>                <0x0 0x4fff0000 0x0 0x00010000>;
>          reg-names = "dbi", "config";
> +        clocks = <&clkc 9>, <&clkc 7>, <&clkc 10>;
> +        clock-names = "core", "dbi", "aux";
>          ranges = <0x81000000 0x0 0x4fbf0000 0x0 0x4fbf0000 0x0 0x00400000>,
>                   <0x82000000 0x0 0x40000000 0x0 0x40000000 0x0 0x0fbf0000>,
>                   <0xc3000000 0x40 0x00000000 0x40 0x00000000 0xd 0x00000000>;
> 
> -- 
> 2.34.1
> 
>

Attachment: signature.asc
Description: PGP signature