Re: [PATCH 1/3] staging: iio: accel: adis16203: fix inclination naming and remove unsupported Y-axis

[Andy Shevchenko]

On Tue, Sep 29, 2026 at 09:48:58PM +0300, Abdelnasser Hussein wrote:
> The ADIS16203 measures inclination around a single axis. As per the
> datasheet, register 0x0C gives a 360-degree output, and 0x0E gives a
> +/- 180-degree output of the exact same measurement.

> The current driver incorrectly maps 0x0E as a separate Y-axis. This patch
> removes the phantom Y-axis, updates the naming, and adjusts the timestamp
> channel index.

Read Submitting Patches about imperative mode (search for "This patch").

> Note: The ADIS_INCLI_CHAN(X, ...) modifier is intentionally kept to
> preserve the existing userspace ABI (incli_x_raw).

This is a staging driver, why do we care about ABI preservations?
Yes, ideally it would be good to have existing user space software
continue working as before, but if this adds a confusion, better to
rework an ABI as well.

> Furthermore, removing
> the phantom Y-axis inherently shifts the scan indexes of subsequent
> channels down by one, which is expected to correct the hardware
> representation.

-- 
With Best Regards,
Andy Shevchenko