Re: patch: new sysctl to remove hardcoded ELOOP limit

Bill Hawes (whawes@transmeta.com)
Thu, 09 Apr 1998 09:21:51 -0700


Chris Evans wrote:

> On Thu, 9 Apr 1998, Peeter Joot wrote:
>
> > Hi,
> >
> > Currently 5 symlinks will be followed before ELOOP is returned. Today
> > I had a need for this to be 6 on my system. Rather than just hacking the
> > value and recompiling it I thought it made more sense to have a sysctl so
> > this is adjustable.
>
> Lovely little patch!!
>
> One comment: isn't there a /proc/sys/fs in 2.1.x? And if so wouldn't the
> value be better suited there?
>
>

I didn't see the original patch, but I don't think it's a good idea to make
ELOOP variable.The reason that there's a hard-coded limit in the first place
is that symlink traversal uses
recursion, and the kernel stack has a hard-coded limit. In addition, it's not
that easy to
figure out worst-case stack usage, since you don't know what various file
systems may
need to do to resolve symlinks.

Hence a hard-coded safe limit is called for here.

Regards,
Bill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu