Re: [PATCH 1/6] nand: davinci: rename the platform driver
From: Boris Brezillon
Date: Fri Feb 16 2018 - 13:32:00 EST
Hi Bartosz
Prefix should be "mtd: nand: davinci:"
On Fri, 16 Feb 2018 17:47:07 +0100
Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> Commit d8e22fb4ccac ("ARM: da850: add the nand dev_id to the clock
> lookup table") broke the nand support in board file mode for
> da850-based boards. Instead of reverting it and breaking the DT users
> in the process (due to clock lookup), rename the driver to match the
> clock table before renaming the users.
>
> Fixes: d8e22fb4ccac ("ARM: da850: add the nand dev_id to the clock lookup table")
You probably want Cc: <stable@xxxxxxxxxxxxxxx> here.
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> ---
> drivers/mtd/nand/davinci_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index ccc8c43abcff..4fb143bf1872 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -865,7 +865,7 @@ static struct platform_driver nand_davinci_driver = {
> .probe = nand_davinci_probe,
> .remove = nand_davinci_remove,
> .driver = {
> - .name = "davinci_nand",
> + .name = "davinci-nand",
And by doing that you're breaking C board files which are using the
name with an underscore.
> .of_match_table = of_match_ptr(davinci_nand_of_match),
> },
> };
Regards,
Boris
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com