Re: [PATCH] init/main.c: mark boot_config_checksum static

[Masami Hiramatsu]

On Sun, 16 Feb 2020 19:28:31 +0800
Qiujun Huang <hqjagain@xxxxxxxxx> wrote:

> In fact, this function is only used in this file, so mark it with 'static'.

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thank you!

> 
> Signed-off-by: Qiujun Huang <hqjagain@xxxxxxxxx>
> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/main.c b/init/main.c
> index f95b014..534589f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -335,7 +335,7 @@ static char * __init xbc_make_cmdline(const char *key)
>  	return new_cmdline;
>  }
>  
> -u32 boot_config_checksum(unsigned char *p, u32 size)
> +static u32 boot_config_checksum(unsigned char *p, u32 size)
>  {
>  	u32 ret = 0;
>  
> -- 
> 1.8.3.1
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>