Re: [f2fs-dev] [PATCH 2/3] f2fs: add migration count iff migration happens

From: Chao Yu
Date: Sun Feb 16 2020 - 20:43:23 EST


BTW

f2fs: add migration count iff migration happens

typo: iff

On 2020/2/15 2:58, Jaegeuk Kim wrote:
> If first segment is empty and migration_granularity is 1, we can't move this
> at all.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> ---
> fs/f2fs/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 65c0687ee2bb..bbf4db3f6bb4 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1233,12 +1233,12 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
> segno, gc_type);
>
> stat_inc_seg_count(sbi, type, gc_type);
> + migrated++;
>
> freed:
> if (gc_type == FG_GC &&
> get_valid_blocks(sbi, segno, false) == 0)
> seg_freed++;
> - migrated++;
>
> if (__is_large_section(sbi) && segno + 1 < end_segno)
> sbi->next_victim_seg[gc_type] = segno + 1;
>