Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace

From: David Miller
Date: Sun Feb 16 2020 - 21:56:03 EST


From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Date: Thu, 13 Feb 2020 14:44:26 +0530

> +static int service_announce_new(struct sockaddr_qrtr *dest,
> + struct qrtr_server *srv)
> +{
> + struct qrtr_ctrl_pkt pkt;
> + struct msghdr msg = { };
> + struct kvec iv = { &pkt, sizeof(pkt) };

Please use reverse christmas tree ordering for local variables.

Please fix this for your entire submission.