Re: [PATCH 5/8] ASoC: sun50i-codec-analog: Enable DAPM for headphone switch

From: Chen-Yu Tsai
Date: Mon Feb 17 2020 - 02:18:19 EST

On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
> By including the headphone mute switch to the DAPM graph, both the
> headphone amplifier and the Mixer/DAC inputs can be powered off when
> the headphones are muted.
> The mute switch is between the source selection and the amplifier,
> as per the diagram in the SoC manual.
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>

Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>

BTW, have you also considered tying in the headphone volume control?
It also has a mute setting.