Re: [PATCH 1/1] powerpc/cputable: Remove unnecessary copy of cpu_spec->oprofile_type

[Leonardo Bras]

On Mon, 2020-02-17 at 09:33 +1100, Michael Neuling wrote:
> On Sat, 2020-02-15 at 02:36 -0300, Leonardo Bras wrote:
> > Before checking for cpu_type == NULL, this same copy happens, so doing
> > it here will just write the same value to the t->oprofile_type
> > again.
> > 
> > Remove the repeated copy, as it is unnecessary.
> > 
> > Signed-off-by: Leonardo Bras <leonardo@xxxxxxxxxxxxx>
> 
> LGTM
> 
> Reviewed-by: Michael Neuling <mikey@xxxxxxxxxxx>
> 

Thanks!

> > ---
> >  arch/powerpc/kernel/cputable.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
> > index e745abc5457a..5a87ec96582f 100644
> > --- a/arch/powerpc/kernel/cputable.c
> > +++ b/arch/powerpc/kernel/cputable.c
> > @@ -2197,7 +2197,6 @@ static struct cpu_spec * __init setup_cpu_spec(unsigned
> > long offset,
> >  		 */
> >  		if (old.oprofile_cpu_type != NULL) {
> >  			t->oprofile_cpu_type = old.oprofile_cpu_type;
> > -			t->oprofile_type = old.oprofile_type;
> >  		}
> >  	}
> >

Attachment: signature.asc
Description: This is a digitally signed message part