Re: Applied "ASoC: core: ensure component names are unique" to the asoc tree

From: Stefan Wahren
Date: Mon Feb 17 2020 - 12:23:42 EST

Am 17.02.20 um 15:36 schrieb Marek Szyprowski:
> Hi Jerome,
> On 17.02.2020 14:18, Jerome Brunet wrote:
>> On Mon 17 Feb 2020 at 13:13, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote:
>>> On 14.02.2020 21:56, Mark Brown wrote:
>>>> Thanks,
>>>> Mark
>>>> From b2354e4009a773c00054b964d937e1b81cb92078 Mon Sep 17 00:00:00 2001
>>>> From: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>>>> Date: Fri, 14 Feb 2020 14:47:04 +0100
>>>> Subject: [PATCH] ASoC: core: ensure component names are unique
>>>> Make sure each ASoC component is registered with a unique name.
>>>> The component is derived from the device name. If a device registers more
>>>> than one component, the component names will be the same.
>>>> This usually brings up a warning about the debugfs directory creation of
>>>> the component since directory already exists.
>>>> In such case, start numbering the component of the device so the names
>>>> don't collide anymore.
>>>> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>>>> Link:
>>>> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
>>> This patch landed in today's linux-next and I've noticed that it breaks
>>> registration of VC4 DRM driver on Raspberry Pi3 boards (I've compiled
>>> kernel from bcm2835_defconfig):
>> I think I have an idea about what is going on. (good catch in the defer BTW)
>> 1) Funny to see that the vc4-hdmi already registers several (3) ASoC
>> components. It must have had warning about the debugfs entry before this patch.
> Okay, right, before this patch there is a warning from debugfs I've
> missed (debugfs was not enabled in bcm2835_defconfig):

This is unintended. I've seen patches which restored DEBUG_FS support
because of this commit:

0e4a459f56c32d tracing: Remove unnecessary DEBUG_FS dependency

Best regards