Re: [PATCH v9 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller

From: Ramuthevar, Vadivel MuruganX
Date: Mon Feb 17 2020 - 22:17:17 EST

Hi Mark,

On 18/2/2020 1:09 AM, Mark Brown wrote:
On Mon, Feb 17, 2020 at 05:18:10PM +0800, Ramuthevar, Vadivel MuruganX wrote:
On 14/2/2020 9:09 PM, Mark Brown wrote:
This will unconditionally handle the interrupt regardless of if the
hardware was actually flagging an interrupt which will break shared
interrupts and the fault handling code in genirq.
Yes, you're correct, it doesn't check unconditionally, will update the
INT flag in the INT_STATUS register after successful completion of
read/write operation.
but in this case it is dedicated to qspi-interrupt,not shared with any other
HW/SW interrupts.
Currently, on the system you're looking at. Given that this is already
a widely reused IP there's no guarantee that this will always be the
case, and like I say even without sharing it also defeats the fault
handling code.
Got it, Thanks! a lot
will take care of it, even though it is not present in the system current,  to avoid future conflicts.
Flagging and check to be added  to avoid  if the interrupt raises from shared  devices.