Re: [PATCH v4] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events

[kajoljain]

On 2/17/20 1:51 AM, Jiri Olsa wrote:
> On Wed, Feb 12, 2020 at 11:11:02AM +0530, Kajol Jain wrote:
> 
> SNIP
> 
>>  
>>  	return metric_events[0];
>> @@ -160,6 +161,14 @@ static int metricgroup__setup_events(struct list_head *groups,
>>  	int ret = 0;
>>  	struct egroup *eg;
>>  	struct evsel *evsel;
>> +	bool *evlist_used;
>> +
>> +	evlist_used = (bool *)calloc(perf_evlist->core.nr_entries,
>> +				     sizeof(bool));
>> +	if (!evlist_used) {
>> +		ret = -ENOMEM;
>> +		break;
> 
> hum, how did this compile for you? ;-)
> 
> util/metricgroup.c: In function âmetricgroup__setup_eventsâ:
> util/metricgroup.c:170:3: error: break statement not within loop or switch
>   170 |   break;
> 
> 
Hi jiri,
        Yes you are right. My bad I send patch from other branch. Will send correct one.
Thanks,
Kajol

> jirka
>