Re: [PATCH v2 4/5] sched/pelt: Add a new runnable average signal
From: Valentin Schneider
Date: Tue Feb 18 2020 - 11:31:34 EST
On 18/02/2020 15:28, Vincent Guittot wrote:
>>> @@ -532,8 +535,8 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
>>> SEQ_printf(m, " .%-30s: %ld\n", "removed.util_avg",
>>> - SEQ_printf(m, " .%-30s: %ld\n", "removed.runnable_sum",
>>> - cfs_rq->removed.runnable_sum);
>> Shouldn't that have been part of patch 3?
> No this was used to propagate load_avg
Right, sorry about that.
>> <fugly here>
> TBH, I prefer keeping the current version which is easier to read IMO
I did call it an eldritch horror :-) I agree with you here, it's a shame we
don't really have better ways to factorize this (I don't think splitting the
inputs is really an alternative).