Re: [PATCH 2/5] iommu/vt-d: Move deferred device attachment into helper function

From: Christoph Hellwig
Date: Tue Feb 18 2020 - 12:16:25 EST


> +static void do_deferred_attach(struct device *dev)
> {
> + struct iommu_domain *domain;
>
> + dev->archdata.iommu = NULL;
> + domain = iommu_get_domain_for_dev(dev);
> + if (domain)
> + intel_iommu_attach_device(domain, dev);
> +}
> +
> +static struct dmar_domain *deferred_attach_domain(struct device *dev)
> +{
> + if (unlikely(attach_deferred(dev)))
> + do_deferred_attach(dev);
>
> return find_domain(dev);
> }

Can we start using proper sybmbol prefixes and avoid do_* names where
possible?