Re: [PATCH v4 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima
From: Mimi Zohar
Date: Tue Feb 18 2020 - 14:37:55 EST
On Tue, 2020-02-18 at 11:25 -0800, Tushar Sugandhi wrote:
> Hi Mimi,
>
> On 2020-02-14 5:47 p.m., Tushar Sugandhi wrote:
> > The kbuild Makefile specifies object files for vmlinux in the $(obj-y)
> > lists. These lists depend on the kernel configuration[1].
> >
> > The kbuild Makefile for IMA combines the object files for IMA into a
> > single object file namely ima.o. All the object files for IMA should be
> > combined into ima.o. But certain object files are being added to their
> > own $(obj-y). This results in the log messages from those modules getting
> > prefixed with their respective base file name, instead of "ima". This is
> > inconsistent with the log messages from the IMA modules that are combined
> > into ima.o.
> >
> > This change fixes the above issue.
> >
> > [1] Documentation\kbuild\makefiles.rst
> >
> Is there any feedback on this patch description?
> I can address it in the next iteration.
No, it looks good to me.
Mimi