Re: [PATCH v2 2/2] ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family

From: Dan Murphy
Date: Tue Feb 18 2020 - 14:39:48 EST


On 2/18/20 1:23 PM, Mark Brown wrote:
On Tue, Feb 18, 2020 at 11:21:40AM -0600, Dan Murphy wrote:

A couple of very small things, otherwise this looks good:

+ if (unlikely(!tx_mask)) {
+ dev_err(component->dev, "tx and rx masks need to be non 0\n");
+ return -EINVAL;
+ }
Do you really need the unlikely() annotation here? This is *hopefully*
not a hot path.

I was copying the code from tlv320aic3x.c as suggested by one our audio guys here in TI.

I can remove it if you desire

+static int adcx140_codec_probe(struct snd_soc_component *component)
+ struct adcx140_priv *adcx140 = snd_soc_component_get_drvdata(component);
+ int sleep_cfg_val = ADCX140_WAKE_DEV;
+ u8 bias_source;
+ u8 vref_source;
+ int ret;
+ adcx140->supply_areg = devm_regulator_get_optional(adcx140->dev,
+ "areg");
+ if (IS_ERR(adcx140->supply_areg)) {
You should really do the request and defer at the I2C level, that avoids
running through the whole card initialization repeatedly when the device
isn't ready. Basically try to do all resource aquisition at the device
level and then use it at the card level.

Ack.  Makes more sense to do it in the I2C probe.