Re: [PATCH v5 1/3] dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for Qualcomm DWC3 driver

From: Rob Herring
Date: Tue Feb 18 2020 - 16:03:02 EST


On Fri, Feb 14, 2020 at 01:54:42PM +0530, Sandeep Maheswaram wrote:
> Add documentation for the interconnects and interconnect-names
> properties for USB.
>
> Signed-off-by: Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index 4a36ab5..236877e 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -68,6 +68,22 @@ properties:
> resets:
> maxItems: 1
>
> + interconnects:
> + description:
> + Pairs of phandles and interconnect provider specifiers
> + to denote the edge source and destination ports of
> + the interconnect path. Please refer to
> + Documentation/devicetree/bindings/interconnect/
> + for more details.

No need to redefine a common property, but you do need to define how
many entries (maxItems).

> +
> + interconnect-names:
> + description:
> + List of interconnect path name strings sorted in the same
> + order as the interconnects property. Consumer drivers will use
> + interconnect-names to match interconnect paths with interconnect
> + specifiers. Please refer to Documentation/devicetree/bindings/
> + interconnect/ for more details.

Need to define what the names are.

Rob