Re: [PATCH 0/3] leds: add support for apa102c leds

From: Jacek Anaszewski
Date: Tue Feb 18 2020 - 16:26:43 EST

Hi Dan,

On 2/18/20 1:43 PM, Dan Murphy wrote:
> Hellp
> On 2/18/20 3:37 AM, Nicolas Belin wrote:
>> This patch series adds the driver and its related documentation
>> for the APA102C RGB Leds.
>> Patch 1 adds the APA102C led manufacturer to the vendor-prefixes list.
>> Patch 2 Documents the APA102C led driver.
>> Patch 3 contains the actual driver code and modifications in the Kconfig
>> and the Makefile.
> Is this something that can benefit from the Multicolor framework patches?
> Can you RFC the APA102C driver on top of the Multicolor FW to see how it
> blends?

Just to let you know - I am currently playing with Samsung Galaxy S3,
which has mainline support, and also with a driver for its RGB LED:
leds-an30259a.c. I am adjusting that driver to LED multicolor class
and I will have certainly some more remarks (also to the variable naming
I proposed myself, which after few months feels awkward to me).

Generally speaking - we have to do everything to make the addition
of LED multicolor support to the driver way easier and more
straightforward since currently it is painful. I would go for
a separate compilation unit for multicolor specifc part of LED drivers.
But I will be able to tell more after few more days.

Best regards,
Jacek Anaszewski