Re: [for-next][PATCH 04/26] bootconfig: Add Extra Boot Config support

[Masami Hiramatsu]

On Tue, 18 Feb 2020 12:57:48 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 18 Feb 2020 14:27:24 +0100
> Borislav Petkov <bp@xxxxxxxxx> wrote:
> 
> > Btw, if you remove the boot config with the tool (-d) and still boot
> > with "bootconfig" it says:
> > 
> > [    0.043958] bootconfig size -23483140 greater than max size 32767
> 
> I was aware of this but after you reported this, I don't like it.

Yeah, it should be avoided.

> 
> Masami,
> 
> Can you add code to insert "magic" text at the start of the bootconfig
> appended to the initrd file? Perhaps just have "BOOTCONFIG", and then
> if it's not there we warn "bootconfig on command line but not found in
> the initrd". I'm starting to not like relying on the size and checksum
> only to determine if the bootconfig exists. We need to get this patch
> before 5.6 is released.

OK, that's a good idea. I also considering to add support bootconfig
chain-loading support (allowing user to append several bootconfigs to
initrd), for making bootloaders to support bootconfig easier. That
will need a magic code too.

Thank you,

-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>