Re: [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc

From: Fabio Estevam
Date: Wed Feb 19 2020 - 07:48:51 EST


Hi Oleksandr,

On Wed, Feb 19, 2020 at 8:57 AM Oleksandr Suvorov
<oleksandr.suvorov@xxxxxxxxxxx> wrote:
>
> SD/MMC on Colibri iMX7S/D modules successfully support
> 200Mhz frequency in HS200 mode.

s/Mhz/MHz

>
> Removing the unnecessary max-frequency limit significantly
> increases the performance:
>
> == before fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
> Timing buffered disk reads: 252 MB in 3.02 seconds = 83.54 MB/sec
> ==================
>
> === after fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
> Timing buffered disk reads: 408 MB in 3.00 seconds = 135.94 MB/sec
> ==================

Nice improvement :-)

>
> Fixes: f928a4a377e4 ("ARM: dts: imx7: add Toradex Colibri iMX7D
> 1GB (eMMC) support")

Please keep the Fixes tag in a single line.

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>