Re: [PATCH v2] x86/mce: Do not log spurious corrected mce errors

[Borislav Petkov]

On Wed, Feb 19, 2020 at 07:25:59AM -0500, Prarit Bhargava wrote:
> When I submitted this patch I looked at other commits in the kernel near
> top-of-tree and they have Signed-off-by followed by Co-developed-by, and also
> took your suggestion of not using a Signed-off-by for Alexander.  That's why I

I said:

"This is not how this is expressed. Either you write that in free text in
the commit message or you use Co-developed-by. More details in

Documentation/process/submitting-patches.rst"

> I'm now thoroughly confused as to what the correct format is.  It seems like
> checkpatch.py is telling me to include a Signed-off-by in addition to the
> Co-developed-by for Alexander but you explicitly told me not to.
>
> > See Documentation/process/submitting-patches.rst for more detail.

You need to start reading my replies in their entirety and finally read that
document I've pointed to twice:

"Co-developed-by: states that the patch was co-created by multiple developers;
it is a used to give attribution to co-authors (in addition to the author
attributed by the From: tag) when several people work on a single patch.  Since
									  ^^^^^
Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
followed by a Signed-off-by: of the associated co-author."
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I.e., basically what checkpatch is saying.

So you either

a) write in free text in the commit message something like

"This is based on a patch submitted to RH bugzilla by Alexander Krupp
<centos@xxxxxxxxxxxx>"

OR

b) use

Co-developed-by: Alexander Krupp <centos@xxxxxxxxxxxx>
Signed-off-by: Alexander Krupp <centos@xxxxxxxxxxxx>

Either a) XOR b).

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette